Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to catch errors when asking multiple questions #607

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Add ability to catch errors when asking multiple questions #607

merged 6 commits into from
Oct 2, 2023

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Sep 28, 2023 •
edited
Loading

Contents (#607)

Enhancements

  • Add ability to catch errors for failed questions and keep answers for successful questions when using Child.ask_multiple

@cortadocodes cortadocodes self-assigned this Sep 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #607 (99a0f24) into main (833cfe7) will increase coverage by 0.59%.
Report is 87 commits behind head on main.
The diff coverage is 93.85%.

❗ Current head 99a0f24 differs from pull request most recent head 953c50f. Consider uploading reports for the commit 953c50f to get more accurate results

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   94.38%   94.97%   +0.59%     
==========================================
  Files          78       75       -3     
  Lines        3436     3303     -133     
==========================================
- Hits         3243     3137     -106     
+ Misses        193      166      -27
Files Coverage Δ
...cloud/deployment/google/answer_pub_sub_question.py 87.50% <100.00%> (ø)
octue/cloud/emulators/_pub_sub.py 93.10% <100.00%> (ø)
octue/cloud/pub_sub/message_handler.py 96.51% <100.00%> (ø)
octue/configuration.py 91.11% <100.00%> (-2.54%) ⬇️
octue/mixins/metadata.py 100.00% <100.00%> (ø)
octue/resources/child.py 100.00% <100.00%> (ø)
octue/resources/datafile.py 93.98% <100.00%> (ø)
octue/runner.py 97.90% <100.00%> (+2.20%) ⬆️
octue/cli.py 88.81% <85.71%> (+2.37%) ⬆️
octue/cloud/pub_sub/service.py 93.08% <90.90%> (-0.40%) ⬇️
... and 2 more

@cortadocodes cortadocodes merged commit 207f378 into main Oct 2, 2023
5 checks passed
@cortadocodes cortadocodes deleted the allow-question-retries-in-ask-multiple branch October 2, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cortadocodes cortadocodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cortadocodes @codecov-commenter